This randomised double blind placebo controlled study evaluated the effectiveness of colloidal bismuth subcitrate (CBS), ampicillin and their combination in the treatment of Helicobacter Pylori in non-ulcer dyspepsia (NUD) and assessed if elimination of this organism is associated with improvement of gastritis and the symptoms. Forty-eight NUD patients with H. pylori and histologic gastritis were randomly allocated to one of the three regimens for 28 days. Symptoms were assessed before and after treatment. Forty-three patients completed the trial. Repeat endoscopy within 48 hours of completing treatment showed suppression of H. pylori in 6 of 7 patients (85.7%) on combined therapy and one of 8 patients (12.5%) on CBS therapy (p = 0.0205). There was no suppression of the bacteria in patients treated with ampicillin. Repeat endoscopy performed 2 weeks after completing treatment showed suppression of H. pylori in 3 of 7 patients (42.9%) on combined therapy and none in the other two groups. Patients on combined therapy who had suppression of H. pylori, 48 hours or 2 weeks after completing treatment were noted to have historical improvement of their gastritis (p = 0.0001 and p = 0.05 respectively). This was also associated with improvement of symptoms in these patients.